Allow masking of multiple substrings #696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, masking of a single value would stop after the first ValueMasker returned a masked value. This meant that only one ValueMasker would process a string. Now, all ValueMaskers are given the opportunity to process a value, which means that multiple substrings can be masked independently by different ValueMaskers Fixes #690
brenuart
approved these changes
Nov 7, 2021
Collaborator
brenuart
left a comment
brenuart
left a comment
There was a problem hiding this comment.
Looks ok to me.
Maybe add a note in the README + changelog about actual behaviour when multiple masks are configured.
philsttr
added
type/bug
warn/api-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, masking of a single value would stop after the first ValueMasker returned a masked value.
This meant that only one ValueMasker would process a string.
Now, all ValueMaskers are given the opportunity to process a value, which means that multiple substrings can be masked independently by different ValueMaskers
Fixes #690